Hello! A couple of minor issues:
guix-comm...@gnu.org skribis: > commit 983550692dbf5a41afef1b1cae53fece42b3d4bf > Author: Pierre Neidhardt <m...@ambrevar.xyz> > Date: Thu Feb 21 19:07:09 2019 +0100 > > gnu: Add hyperledger-fabric. > > * gnu/local.mk (hyperledger): New variable. Really? :-) > + (replace 'build > + (lambda _ > + ;; Only linux-amd64 and linux-ppc64le seem to be supported at > the moment. > + (invoke "make" "-C" "src/github.com/hyperledger/fabric" > + "release/linux-amd64"))) I don’t know how much of a difference it makes in this case but it might be worth considering passing “-j” (number->string (parallel-job-count)). > + (copy-recursively > + "release/linux-amd64/bin" Is this really limited to x86_64-linux? If so, please add a ‘supported-systems’ field. Then again, this “linux-amd64” thing looks worrying: can you confirm the checkout doesn’t contain pre-built binaries? > + (synopsis "Platform for distributed ledger solutions") > + (description "A platform for distributed ledger solutions, underpinned by > +a modular architecture delivering high degrees of confidentiality, > resiliency, > +flexibility and scalability.") Please turn the description into a sentence, and ideally something less marketing-ish. :-) Thanks, Ludo’.