Hi Steve, As your are now familiar with git you can use the H2 git repository to make better patch support:
https://github.com/svn2github/H2-Mirror I will follow your fork and maybe send you some code proposition. Regards, Nicolas Le mercredi 4 février 2015 14:04:04 UTC+1, Steve a écrit : > > some comments from my sid to your suggestions: > > - should be in the API package > -> you are right! > - wrapper > -> I understand your intention behind that... currently I do something > like that in H2GIS's SpatialResultSetImpl > > @Override > public Geometry getGeometry(String columnLabel) throws SQLException > { > Object field = getObject(columnLabel); > if (field == null) > { > return null; > } > if (field instanceof H2Geometry) > { > return ((H2Geometry) field).getJtsGeometry(); > } > else > { > throw new SQLException("The column " + columnLabel + " is not a > Geometry"); > } > } > > - Default Implementation: > A default implementation itself makes sense because H2 should be able > to test their spatial index. Therefore I would suggest to implement a > H2Envelope, H2Geometry, H2GeometryFactory or we can call it JTSEnvelope > etc... which uses the JTS framework. > The default implementation can be provided by a different jar or by > H2GIS. > > - SysProperties to change the implementation > That could be alternative solution. I suggested the ServiceLoader > > <http://docs.oracle.com/javase/7/docs/api/index.html?java/util/ServiceLoader.html>because > > of the fact that I'm a fan of that framework :D and > java.sql.DriverManager > <http://docs.oracle.com/javase/7/docs/api/java/sql/DriverManager.html> > uses also the Service Provider mechanism > > - specific geometry types: > I think you need that to support the whole OGC Simple Feature > Specification for SQL, therefore I understand your need. > From my point of view is the only necessary step to define additional > H2 DataTypes. The spatial index and all ohther mechanism's can be the same. > > -- You received this message because you are subscribed to the Google Groups "H2 Database" group. To unsubscribe from this group and stop receiving emails from it, send an email to h2-database+unsubscr...@googlegroups.com. To post to this group, send email to h2-database@googlegroups.com. Visit this group at http://groups.google.com/group/h2-database. For more options, visit https://groups.google.com/d/optout.
