[
https://issues.apache.org/jira/browse/HADOOP-1041?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12475939
]
James P. White commented on HADOOP-1041:
----------------------------------------
You might consider resource bundles for handling the name prettifying. That
provides good decoupling and enables folks who care about how the names look to
add the names without impacting other folks who might be creating the counters.
Using a property ResourceBundle would let you make a file like:
HadoopPresentation_en.properties
-------------
org.apache.hadoop.examples.RandomWriter$Counters#BYTES_WRITTEN=Number of bytes
randomly written
And code like:
ResourceBundle res = ResourceBundle.getBundle("HadoopPresentation");
...
String presentableName(final String key)
{
try {
return res.getString(key);
} catch (final MissingResourceException e) {
return key;
}
}
http://java.sun.com/developer/technicalArticles/Intl/ResourceBundles/
> Counter names are ugly
> ----------------------
>
> Key: HADOOP-1041
> URL: https://issues.apache.org/jira/browse/HADOOP-1041
> Project: Hadoop
> Issue Type: Improvement
> Components: mapred
> Affects Versions: 0.12.0
> Reporter: Owen O'Malley
> Fix For: 0.12.0
>
>
> Having the complete class name in the counter names makes them unique, but
> they are ugly to present to non-developers. It would be nice to have some way
> to have a nicer string presented to the user. Currently, the Enum is
> converted to a name like:
> key.getDeclaringClass().getName() + "#" + key.toString()
> which gives counter names like
> "org.apache.hadoop.examples.RandomWriter$Counters#BYTES_WRITTEN"
> which is unique, but not very user friendly. Perhaps, we should strip off the
> class name for presenting to the users, which would allow them to make nice
> names. In particular, you could define an enum type that overloaded toString
> to print a nice user friendly string.
> Thoughts?
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
