[
https://issues.apache.org/jira/browse/HADOOP-1041?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12475962
]
James P. White commented on HADOOP-1041:
----------------------------------------
On sorting I would mostly agree that a good starting point would be to keep it
simple in the way you propose. As a future enhancement things could get more
involved by adding things like grouping and sorting attributes to the keys.
The reason I hesitate to tackle the grouping right now is I don't know enough
about the actual application scenarios and it is easy to over-engineer such
things.
But one thing on sorting of keys vs. names is that it might be worthwhile to
make it easy to choose which one to use because keys are already grouped by
package and that might be what is desired.
And yes, the reason I gave "HadoopPresentation_en.properties" as an example was
to refer to the internationalization aspect. In practice, English names would
probably go in the default file ("HadoopPresentation.properties") while
localized names would go in the more specialized files. For someone who found
that approach inconvenient, it would be easy to rename the default file.
> Counter names are ugly
> ----------------------
>
> Key: HADOOP-1041
> URL: https://issues.apache.org/jira/browse/HADOOP-1041
> Project: Hadoop
> Issue Type: Improvement
> Components: mapred
> Affects Versions: 0.12.0
> Reporter: Owen O'Malley
> Fix For: 0.12.0
>
>
> Having the complete class name in the counter names makes them unique, but
> they are ugly to present to non-developers. It would be nice to have some way
> to have a nicer string presented to the user. Currently, the Enum is
> converted to a name like:
> key.getDeclaringClass().getName() + "#" + key.toString()
> which gives counter names like
> "org.apache.hadoop.examples.RandomWriter$Counters#BYTES_WRITTEN"
> which is unique, but not very user friendly. Perhaps, we should strip off the
> class name for presenting to the users, which would allow them to make nice
> names. In particular, you could define an enum type that overloaded toString
> to print a nice user friendly string.
> Thoughts?
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
