+1 to Doug's comments.
On Mar 22, 2007, at 2:03 PM, Doug Cutting (JIRA) wrote:
[ https://issues.apache.org/jira/browse/HADOOP-1148?
page=com.atlassian.jira.plugin.system.issuetabpanels:comment-
tabpanel#action_12483321 ]
Doug Cutting commented on HADOOP-1148:
--------------------------------------
is there a consensus in this developer community that two spaces
are better than four?
To make a change, we'd need a consensus that four are better than
two. Two has been the stated goal since the project's inception.
I prefer two because it permits more code per line while staying
with 80 columns and using descriptive identifiers. I always edit
in 80-column windows. Four spaces per indent level can quickly use
nearly half the columns, with nested classes, anonymous methods,
try/catch blocks, etc. It's nice when, e.g., 3-parameter method
calls, where the method name and each parameter name might have ten
characters, can be written on a single line, without wrapping each
parameter to a separate line. I've never found two-space
indentation to make code any less readable.
re-indent all code
------------------
Key: HADOOP-1148
URL: https://issues.apache.org/jira/browse/
HADOOP-1148
Project: Hadoop
Issue Type: Improvement
Reporter: Doug Cutting
Assigned To: Doug Cutting
Priority: Minor
We should re-indent all code to consistently use 2-spaces per
level. This will not invalidate outstanding patches: one can use
the '-l' option to ignore whitespace differences in patches.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
