Nigel Daley wrote:
Should a +1 code review comment be required a) before "Submit Patch" b) after "Submit Patch" c) either before or after ?
I'd vote for (c). Setting something to "Submit Patch" is a good way to request a review. But if someone posts a speculative patch that they're not yet comfortable marking "Patch Available", and someone reviews it, that's okay too. The final review is always the responsibility of the committer who commits it. Other reviews are advisory. And of course, committers shouldn't be the sole reviewers of their own patches.
Doug
