[ https://issues.apache.org/jira/browse/HADOOP-1260?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12489492 ]
Doug Cutting commented on HADOOP-1260: -------------------------------------- We should note either here or on the HowToContribute page that performance optimizations should be validated by benchmarks. > need code review guidelines > --------------------------- > > Key: HADOOP-1260 > URL: https://issues.apache.org/jira/browse/HADOOP-1260 > Project: Hadoop > Issue Type: Improvement > Components: build > Reporter: Nigel Daley > > Following the improvements to the Hadoop release process (HADOOP-1161), it > would be helpful to better document what a code review should entail. I've > posted a proposal here (not yet linked to from anywhere): > http://wiki.apache.org/lucene-hadoop/CodeReviewChecklist > Thoughts? -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.