[
https://issues.apache.org/jira/browse/HADOOP-1425?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12498824
]
Doug Cutting commented on HADOOP-1425:
--------------------------------------
> The problem with ToolBase in my opinion is it is the wrong abstraction.
That's a little strong, I think. It's the right abstraction for some things,
but perhaps not everything. If your class is already subclassing something
else, then ToolBase may not be not right for you. I'm sorry you have trouble
remembering the difference between 'run' and 'doMain'. Perhaps these could be
better named? Do you also find Thread#start() and Thread#run() confusing?
These are analogous with those.
> All I am recommending is to make parseGeneralOptions() public.
That's fine with me. Still, unless a class is already subclassing something
else and cannot use ToolBase, I'd rather see something like my first example
above (subclassing ToolBase) than my second example above (which doesn't
subclass and is more complicated). Lines of code aren't everything, but, when
all else is equal, fewer are better, no?
> Rework the various programs in 'examples' to extend ToolBase
> -------------------------------------------------------------
>
> Key: HADOOP-1425
> URL: https://issues.apache.org/jira/browse/HADOOP-1425
> Project: Hadoop
> Issue Type: Improvement
> Components: examples
> Reporter: Arun C Murthy
> Assigned To: Enis Soztutar
> Priority: Minor
> Fix For: 0.14.0
>
>
> Ensuring all 'examples' extend ToolBase will make it easy to tweak various
> config params (via -D switches for e.g.) while running the programs...
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
