[
https://issues.apache.org/jira/browse/HADOOP-1509?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12506720
]
stack commented on HADOOP-1509:
-------------------------------
James:
+ Why make HClient.getConf public rather than protected? (You refer to 'server'
when you mean 'client' in the javadoc)
+ Regards HClient.getOpenServers, is it wise letting out the servers data
structure? Access probably needs to be synchronized. Would wrapping the
servers map returned by getOpenServers with an Arrays.unmodifiableMap be
obnoxious? (Probably) Better might be adding (synchronized) 'servers'
manipulating methods to the base HClient class?
+ Does HRegion need to be public? It would be better if HRegions were only
manipulated by HRegionServers since instantation of a HRegion will change the
on-hdfs state, a problem if two instances of HRegion are pointed at same region
(But maybe your subclass of HRegionServer cannot use HRegion unless its
public?) Same for its internal scanner.
Otherwise patch looks good. It applied cleanly and passed all tests.
> Open HRegionServer/HClient for extension
> ----------------------------------------
>
> Key: HADOOP-1509
> URL: https://issues.apache.org/jira/browse/HADOOP-1509
> Project: Hadoop
> Issue Type: Improvement
> Components: contrib/hbase
> Affects Versions: 0.14.0
> Reporter: James Kennedy
> Assignee: James Kennedy
> Priority: Minor
> Fix For: 0.14.0
>
> Attachments: openForExtension-v2.patch, openForExtension.patch
>
>
> For what i'm doing I found it necessary to extend
> HRegionServer/HRegion/HClient for some custom functionality.
> Following good Java practice I see that the HBase code as been programmed
> defensively, keeping stuff private as much as possible.
> However, for extensibility it would be nice if the servers/client were easy
> to extend.
> Attached is a patch that makes several methods protected instead of private,
> adds getters to fields of inner classes, and some other modifications i found
> were useful for some simple extension code.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
