[ https://issues.apache.org/jira/browse/HADOOP-1936?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12529712 ]
Hadoop QA commented on HADOOP-1936: ----------------------------------- -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12366410/WordCountTestExampleAndOutputCollectorTestHelper.patch against trunk revision r578348. @author +1. The patch does not contain any @author tags. javadoc +1. The javadoc tool did not generate any warning messages. javac +1. The applied patch does not generate any new compiler warnings. findbugs -1. The patch appears to introduce 4 new Findbugs warnings. core tests +1. The patch passed core unit tests. contrib tests -1. The patch failed contrib unit tests. Test results: http://lucene.zones.apache.org:8080/hudson/job/Hadoop-Patch/810/testReport/ Findbugs warnings: http://lucene.zones.apache.org:8080/hudson/job/Hadoop-Patch/810/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Checkstyle results: http://lucene.zones.apache.org:8080/hudson/job/Hadoop-Patch/810/artifact/trunk/build/test/checkstyle-errors.html Console output: http://lucene.zones.apache.org:8080/hudson/job/Hadoop-Patch/810/console This message is automatically generated. > WordCount unit test plus a helper class to facilitate testing Mappers and > Reducers > ---------------------------------------------------------------------------------- > > Key: HADOOP-1936 > URL: https://issues.apache.org/jira/browse/HADOOP-1936 > Project: Hadoop > Issue Type: Test > Components: examples > Reporter: Kate Rhodes > Priority: Trivial > Attachments: WordCountTestExampleAndOutputCollectorTestHelper.patch > > > There are to pieces to this The first is a test for WordCount, not because > word count actually needed one but because it would be useful to beginners to > have an example of how to unit test Mappers and Reducers. > The second piece is AOutputCollector and it's associated unit test > TestAOutputCollector. This is an abstract class that can be quickly extended > by a stub OutputCollector in your unit tests to collect the output from your > Mapper and Reducer tests and make it available for easy retreival when > testing to see if the fourth key that was emitted was the one you expected. > I think that this would be a useful tool to have in the main test folder but > wasn't sure where would be best to put it. Also, since nothing else in Hadoop > uses Hungarian notation you'll probably want to rename it. I didn't because > I'm not confident about the naming conventions here and figured that since it > and its test probably wouldn't end up living in the same folder as WordCount > that you could just rename it when you moved it. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.