[ 
https://issues.apache.org/jira/browse/HADOOP-1298?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12549521
 ] 

Tsz Wo (Nicholas), SZE commented on HADOOP-1298:
------------------------------------------------

> So, most of the work is done twice : locking and traversing the tree (note 
> that traversing takes a quite a bit of path and string operations).

My current patch only  optimizes memory usage but not CPU usage since CPU usage 
is not critical compared to memory in NameNode.  I will run some test later on 
to see whether there is a need to do the improvement.

> And strictly speaking, it is not correct.

Why is it not correct?  Can you explain more?

> You can remove DFSFileInfo. As part of HADOOP-2336, I am adding owner, group, 
> and permission to FileStatus, which is what DFSFileInfo adds.

I guess you are probably right to put it in FileStatus, instead of DFSFileInfo, 
although some file systems do not support permission.  I will move permissions 
to FileStatus.

> I don't see need for PermissionStatus as well, but that might more of 
> convenience class.

Yes, PermissionStatus makes the codes simpler.

> adding user info to file
> ------------------------
>
>                 Key: HADOOP-1298
>                 URL: https://issues.apache.org/jira/browse/HADOOP-1298
>             Project: Hadoop
>          Issue Type: New Feature
>          Components: dfs, fs
>            Reporter: Kurtis Heimerl
>            Assignee: Christophe Taton
>         Attachments: 1298_2007-09-22_1.patch, 1298_2007-10-04_1.patch, 
> 1298_20071206b.patch, hadoop-user-munncha.patch17
>
>
> I'm working on adding a permissions model to hadoop's DFS. The first step is 
> this change, which associates user info with files. Following this I'll 
> assoicate permissions info, then block methods based on that user info, then 
> authorization of the user info. 
> So, right now i've implemented adding user info to files. I'm looking for 
> feedback before I clean this up and make it offical. 
> I wasn't sure what release, i'm working off trunk. 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to