[ https://issues.apache.org/jira/browse/HADOOP-2344?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Doug Cutting updated HADOOP-2344: --------------------------------- Status: Open (was: Patch Available) This looks mostly good. A few problems: - public and protected methods on public classes need javadoc - SimpleCommandExecutor needs javadoc - inReader and errReader should be closed in a 'finally' clause - there's an empty 'else' clause that should be deleted. > Free up the buffers (input and error) while executing a shell command before > waiting for it to finish. > ------------------------------------------------------------------------------------------------------ > > Key: HADOOP-2344 > URL: https://issues.apache.org/jira/browse/HADOOP-2344 > Project: Hadoop > Issue Type: Bug > Affects Versions: 0.15.2 > Reporter: Amar Kamat > Assignee: Amar Kamat > Fix For: 0.15.2 > > Attachments: HADOOP-2231.patch, HADOOP-2344.patch > > > Process.waitFor() should be invoked after freeing up the input and error > stream. While fixing https://issues.apache.org/jira/browse/HADOOP-2231 we > found that this might be a possible cause. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.