[ 
https://issues.apache.org/jira/browse/HADOOP-2344?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12550140
 ] 

Doug Cutting commented on HADOOP-2344:
--------------------------------------

Arun: In HADOOP-1553, I don't recall hung threads as an issue, but rather 
simply performance.  We never figured out why the performance was bad when 
using Java threads to handle voluminous sub-process output.  But, in this case, 
where we don't expect huge outputs, that may be less of an issue.

It might be worth developing a standalone benchmark that repeatedly spawns a 
process that writes to standard error and/or output in order to test various 
approaches.  If we cannot figure out how to write an efficient thread-based 
version, then perhaps we should change ShellCommand to redirect outputs to 
temporary files, but I'd rather avoid that if we can.


> Free up the buffers (input and error) while executing a shell command before 
> waiting for it to finish.
> ------------------------------------------------------------------------------------------------------
>
>                 Key: HADOOP-2344
>                 URL: https://issues.apache.org/jira/browse/HADOOP-2344
>             Project: Hadoop
>          Issue Type: Bug
>    Affects Versions: 0.15.2
>            Reporter: Amar Kamat
>            Assignee: Amar Kamat
>             Fix For: 0.15.2
>
>         Attachments: HADOOP-2231.patch, HADOOP-2344.patch
>
>
> Process.waitFor() should be invoked after freeing up the input and error 
> stream.  While fixing https://issues.apache.org/jira/browse/HADOOP-2231 we 
> found that this might be a possible cause.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to