[
https://issues.apache.org/jira/browse/HADOOP-2512?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12555813#action_12555813
]
rangadi edited comment on HADOOP-2512 at 1/3/08 9:48 PM:
--------------------------------------------------------------
> Earlier I did append and here I am doing insert thus putting the exit code
> message on the top. In your patch the exit code will be in the end, no?
That is inside ' {{if (errMsg.length() == 0) { ..}} ', so {{append()}} and
{{insert(0)}} are the same. I am missing something?
I am not sure what the policy should be regd errmsg. I would prefer not to
modify it at all and let the user get exit code from {{getExitCode()}}. Here, I
am just fixing code to align with the intent in HADOOP-2344.
was (Author: rangadi):
> Earlier I did append and here I am doing insert thus putting the exit
code message on the top. In your patch the exit code will be in the end, no?
That is inside '{{if (errMsg.length() == 0) { .. }}', so {{append()}} and
{{insert(0)}} are the same. I am missing something?
I am not sure what the policy should be regd how errmsg. I would prefer not to
modify it at all and let the user get exit code from {{getExitCode()}}. Here, I
am just fixing code to align with the intent in HADOOP-2344.
> error stream handling in Shell executor
> ----------------------------------------
>
> Key: HADOOP-2512
> URL: https://issues.apache.org/jira/browse/HADOOP-2512
> Project: Hadoop
> Issue Type: Bug
> Components: util
> Affects Versions: 0.16.0
> Reporter: Raghu Angadi
> Assignee: Raghu Angadi
> Priority: Blocker
> Fix For: 0.16.0
>
> Attachments: HADOOP-2512.patch
>
>
> Fix a couple of issues while handling error stream in Shell (added in
> HADOOP-2344) :
> # fix typo in {{System.getProperty("line.seperator")}}, currently it adds
> "null" instead of "\n".
> # completed is not set to {{true}} when a process exits with an error.
> # In normal error case, it reads errMsg (to create IOException) before
> waiting for errThread to complete, which results in in consistent error
> message. I will attach a patch.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
