[ https://issues.apache.org/jira/browse/HADOOP-2512?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12556292#action_12556292 ]
Hadoop QA commented on HADOOP-2512: ----------------------------------- +1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12372431/HADOOP-2512.patch against trunk revision . @author +1. The patch does not contain any @author tags. javadoc +1. The javadoc tool did not generate any warning messages. javac +1. The applied patch does not generate any new compiler warnings. findbugs +1. The patch does not introduce any new Findbugs warnings. core tests +1. The patch passed core unit tests. contrib tests +1. The patch passed contrib unit tests. Test results: http://lucene.zones.apache.org:8080/hudson/job/Hadoop-Patch/1479/testReport/ Findbugs warnings: http://lucene.zones.apache.org:8080/hudson/job/Hadoop-Patch/1479/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Checkstyle results: http://lucene.zones.apache.org:8080/hudson/job/Hadoop-Patch/1479/artifact/trunk/build/test/checkstyle-errors.html Console output: http://lucene.zones.apache.org:8080/hudson/job/Hadoop-Patch/1479/console This message is automatically generated. > error stream handling in Shell executor > ---------------------------------------- > > Key: HADOOP-2512 > URL: https://issues.apache.org/jira/browse/HADOOP-2512 > Project: Hadoop > Issue Type: Bug > Components: util > Affects Versions: 0.16.0 > Reporter: Raghu Angadi > Assignee: Raghu Angadi > Priority: Blocker > Fix For: 0.16.0 > > Attachments: HADOOP-2512.patch > > > Fix a couple of issues while handling error stream in Shell (added in > HADOOP-2344) : > # fix typo in {{System.getProperty("line.seperator")}}, currently it adds > "null" instead of "\n". > # completed is not set to {{true}} when a process exits with an error. > # In normal error case, it reads errMsg (to create IOException) before > waiting for errThread to complete, which results in in consistent error > message. I will attach a patch. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.