On Sat, Sep 10, 2011 at 09:59:46AM +0200, Finn Arne Gangstad wrote:
> On Fri, Sep 09, 2011 at 09:03:15PM +0200, Willy Tarreau wrote:
> > Hi Finn,
> > 
> > Yes, thanks for the update, I noticed this too and fixed it during
> > tests. I'm OK with this method. I have just replaced the macros with
> > inline functions (which I verified produced the same code) because
> > the result is more readable. And I removed the typedef, as I consider
> > that typedefs for scalars just add obfuscation, but I know it's a
> > matter of taste.
> > 
> > I'm about to merge the attached patch, unless you raise your hand in
> > a very short time ;-)
> 
> Thanks, it's much nicer like this! The typedef was only there to
> support the two different macro versions since they needed different
> types in the delimiter. 

Perfect. I've merged it.

Thanks for the quick feedback,
Willy


Reply via email to