Hi Andrew,

On Tue, Apr 28, 2015 at 10:54:58AM -0500, Andrew Hayworth wrote:
(...)
> I changed %HR -> %HU, and mentioned '(path)' in the docs.

I found it was not changed in the parser nor the doc but I fixed it, don't
worry.

> > Now concerning the bug, it's not very important but it does exist :
> 
> Good catch - Suffice it to say I've tested this patch a bit more thoroughly. 
> :-)
> 
> After a little reflection and during testing, I also found it
> confusing that the new
> directives sometimes logged "<BADREQ>" and sometimes parsed as much as
> they could out of the request line before giving up. This latest patch
> more consistently
> logs "<BADREQ>" if the line is bad. I ended up counting spaces, based on the
> premise that any valid request in any version of the protocol must
> contain at least
> one whitespace character.

That's a good idea indeed.

Thanks for your patience, I've now merged your work. That will definitely
be useful in a number of circumstances.

Cheers,
Willy


Reply via email to