On Mon, May 09, 2016 at 01:30:51PM +0200, Willy Tarreau wrote: > Hello Maxime, > > On Mon, May 09, 2016 at 11:17:25AM +0200, Maxime de Roucy wrote: > > > I have another comment here, please try to factor the error messages > > > using a goto, this block appears at least 3 times : > > > > I tried to use goto but there is always a slight difference in the > > Alert(...) calls, so there is quite as many label as Alert call. > > I had the impression that the error messages were the same, maybe I > have not seen well.
I've rechecked and indeed there are some tiny differences, and the only two identical ones will be merged once you switch to strdup(), so that's fine. Regards, Willy
