turns out the fix seems to be quite a simple and straightforward one (less complicated than expected) i've applied the patch and can confirm that it's working flawlessly (now on 1.7!) many thanks willy and chris for the quick fix!
On 28 November 2016 at 23:06, Christopher Faulet < christopher.fau...@capflam.org> wrote: > Le 26/11/2016 à 16:10, Willy Tarreau a écrit : > >> Hello, >> >> On Sat, Nov 26, 2016 at 04:19:08PM +0800, Live Dev wrote: >> >>> Hello, >>> >>> this is actually my first time posting to the mailing list >>> >> >> Welcome then :-) >> >> really excited to hear about the 1.7 release and thrilled to try out the >>> new features like SPOE and OpenSSL 1.1.0 support >>> >>> kudos to willy and all others who made this happen! >>> >>> however in my use case (which utilizes CONNECT requests, alongside GET >>> and >>> POST) some initial testing shortly following an upgrade to 1.7 seems to >>> suggest i'm hitting a bug at the CONNECT requests >>> >> >> Hmmm you're perfectly right, I've just reproduced it. I could bisect it, >> it was brought by the patch below. I'm very surprized that none of us had >> detected it yet, as this bug has been present for a while now. It probably >> means that few people experiment with development code in front of proxies >> (which probably makes sense) : >> >> commit d7c9196ae56e8ee6babca07ec2ec98a4146bcfd1 >> Author: Christopher Faulet <cfau...@qualys.com> >> AuthorDate: Thu Apr 30 11:48:27 2015 +0200 >> Commit: Willy Tarreau <w...@1wt.eu> >> CommitDate: Tue Feb 9 14:53:15 2016 +0100 >> >> MAJOR: filters: Add filters support >> >> This patch adds the support of filters in HAProxy. The main idea is >> to have a >> way to "easely" extend HAProxy by adding some "modules", called >> filters, that >> will be able to change HAProxy behavior in a programmatic way. >> >> It will not be the funniest one to debug (at least for me), but it's very >> easy to reproduce. I guess it's related to the changes on the forwarding >> path to insert the data hooks. I'll check this on Monday with Chris who >> knows this part very well. We'll also have to check that Upgrade still >> works correctly. >> > > Hi, > > Here is the patch. It fixed the CONNECT requests. The bug affects only > these requests. The HTTP connection upgrade is not concerned here (I've > checked it with the WebSockets). > > -- > Christopher >
