Hi Tim, On Sun, Nov 12, 2017 at 05:39:18PM +0100, Tim Düsterhus wrote: > From: Tim Duesterhus <t...@bastelstu.be> > > If haproxy is started using the name of the binary only (i.e. > not using a relative or absolute path) the `execv` in > `mworker_reload` fails with `ENOENT`, because it does not > examine the `PATH`: > > [WARNING] 315/161139 (7) : Reexecuting Master process > [WARNING] 315/161139 (7) : Cannot allocate memory > [WARNING] 315/161139 (7) : Failed to reexecute the master processs [7] > > The error messages are misleading, because the return value of > `execv` is not checked. This should be fixed in a separate commit. > > Once this happened the master process ignores any further > signals sent by the administrator. >
Well, in my opinion the return value does not need to be checked because we should never reach the code after the exec, that means that the code after the exec is only reached during an exec error. But we could at least display the error code of exec and return afterwards. However, in the case of an exec failure, the master-worker should always work, and so it should be able to receive signals. I spot two other problems in this code path, I'll fix them shortly. > Replace `execv` with `execvp` to establish the expected > behaviour. Willy, could you please apply this patch? thanks -- William Lallemand
