On Wed, Jan 17, 2018 at 02:25:59PM +0100, Pierre Cheynier wrote: > Hi, > > On 16/01/2018 18:48, Olivier Houchard wrote: > > > > Not really :) That's not a case I thought of. > > The attached patch disables the generation of the dynamic cookie if the IP > > is 0.0.0.0 or ::, so that it only gets generated when the server gets a real > > IP. Is it OK with you ? > I'm not sure this will fix the issue. > In this blogpost > https://www.haproxy.com/fr/blog/dynamic-scaling-for-microservices-with-runtime-api/, > the example given is > > server-template websrv 1-100192.168.122.1:8080check disabled > > Which in fact will do exactly the same as 1 hundred times > > server websrvN 192.168.122.1:8080 check disabled > > right ? > (I just confirmed that BTW, by switching my 'high-level' templating to > HAProxy's one, and I reproduce the issue). > > So, as a conclusion, I'm just not sure that producing this warning is > relevant in case the IP is duplicated for several servers *if they are > disabled*... >
Or maybe we should just advocate using 0.0.0.0 when we mean "no IP" :) It would be a bit painful, though doable, to don't check if the server is disabled, but to add the check when server is enabled. I don't know if it's worth it. Regards, Olivier
