> > > I also fixed the memory leaks that you pointed out. (I think) But I did > > notice that > > valgrind reports that the 'newnameserver' allocation is being leaked > > anyway, both > > when using parse-resolv-conf as well as the regular nameserver > > directive...Let > > me know if I should do something about that. To me it seems the resolvers > > code > > should be freeing that. > > It means there's nothing in the deinit() function to take care of the > nameservers. It would be better to do it just to avoid the warnings > you're seeing. Do not hesitate to propose a patch for this if you want, > and please mark it for backporting. >
Sounds good. > > +resolv_out: > > + if (sk != NULL) > > + free(sk); > > Here you don't need the test because free(NULL) is a NOP. > Ah, thanks. For some reason I thought free(NULL) was undefined behavior. > > If you want I can take care of them when merging. Let's wait for Baptiste's > ACK now. > Please do, thanks!
