Willy,

Am 15.01.19 um 21:41 schrieb Willy Tarreau:
>> Ideally the peers would exchange their local values, only.
> 
> Yes and that's how this currently works.

I believe they exchange what they believe to be the current global
connection count, instead of their local connection count, no?

>> These are
>> obviously correct (otherwise it would be broken even without peers).
>> Then the instances aggregate the values (e.g. sum up all the values for
>> the number of connections) themselves to get the correct value.
> 
> That's exactly how HapTech's stick-table aggregator works :-)

Ha! So, I'm not inventing something new here.

>>>
>>> OK I'm merging Tim's patch now.
>>>
>>
>> It was not meant for actually applying (that's why it was missing out on
>> backport information as well),
> 
> Bah, too late, misunderstood, sorry :-)

I was just being unclear. My fault. I'll add a fat "PROOF OF CONCEPT"
warning the next time.

>> because fixing just one counter is fixing
>> the symptoms. I suspect the other stick table values are affected from a
>> possible underflow as well.
> 
> I've checked the rest of the related code for variations and only this
> key works like a gauge, up and down. The other ones in the worst case will
> simply lose some counts but will not face such a problem.

Okay. I guess my patch is the best short term solution then.

Best regards
Tim Düsterhus

Reply via email to