Hi Tim,

On Wed, Jan 08, 2020 at 10:54:47PM +0100, Tim Duesterhus wrote:
> global
>       lua-prepend-path /etc/haproxy/lua-modules/?/init.lua
>       lua-prepend-path /etc/haproxy/lua-modules/?.lua
>       lua-load /etc/haproxy/lua-modules/auth-request.lua

(...)
> diff --git a/doc/configuration.txt b/doc/configuration.txt
> index d0bb97415..47a4db344 100644
> --- a/doc/configuration.txt
> +++ b/doc/configuration.txt
> @@ -1080,6 +1081,11 @@ lua-load <file>
>    This global directive loads and executes a Lua file. This directive can be
>    used multiple times.
>  
> +lua-prepend-path <string>
> +  Prepends the given string followed by a semicolon to Lua's search path.
> +
> +  see: https://www.lua.org/pil/8.1.html
> +

I'm personally not opposed to this at all, however after reading the link
above and given that Lua's concept of "path" is all but obvious as described
in the link above, we definitely need a bit more text in the doc to quickly
explain that the path is rather a pattern and that the question mark is
replaced by the file in "require", and probably put a short example. Having
the link for more details is fine but not as a redirect to figure how to
use the config keyword.

Thanks!
Willy

Reply via email to