Christopher, Am 31.08.20 um 10:36 schrieb Christopher Faulet: > There is no applet for uncached requests. So there is no reason to call > the release callback function. Looking at your 4th patch, you should > manually release 'if_none_match' variable for uncached requests in the > http_action_req_cache_use() function.
Ah, you are correct of course. What solution would you prefer here? 1. Manually freeing in the else part of `if(res)` 2. Moving the whole If-N-M logic down into the `si_register_handler` part? I initially didn't do this, because I assumed that this was within a lock, but now I realize that there's an unlock before the `si_register_handler`. > Another comment, it could be good to test the return value for > http_replace_res_status() and http_replace_res_reason() calls. > That makes sense. I've already adjusted my local branch. Best regards Tim Düsterhus
