Le 01/09/2020 à 18:32, Tim Duesterhus a écrit :
William,
Christopher,
Am 01.09.20 um 10:29 schrieb Christopher Faulet:
There is no applet for uncached requests. So there is no reason to call
the release callback function. Looking at your 4th patch, you should
manually release 'if_none_match' variable for uncached requests in the
http_action_req_cache_use() function.
Ah, you are correct of course. What solution would you prefer here?
1. Manually freeing in the else part of `if(res)`
2. Moving the whole If-N-M logic down into the `si_register_handler`
part? I initially didn't do this, because I assumed that this was within
a lock, but now I realize that there's an unlock before the
`si_register_handler`.
The second one is probably the best.
Okay, I've adjusted this.
I believe the patch is ready for a final review and merge now. Valgrind is
happy and both the old and new reg-tests pass.
Best regards
It seems good for me. If it's good too for William, I will merge it.
Thanks,
--
Christopher Faulet
