Willy, I've eyeballed the full diff to verify that this does not introduce any accidental logic changes. It looks good to me, but of course I might have missed anything.
The coccinelle patch can be found in the commit message. It's very simple, but on the other hand I'm lacking coccinelle experience. So it might be wrong in specific edge cases. All in all: Apply with care. Best regards Tim Düsterhus (3): CLEANUP: Compare the return value of `XXXcmp()` functions with zero CLEANUP: Apply the coccinelle patch for `XXXcmp()` on include/ CLEANUP: Apply the coccinelle patch for `XXXcmp()` on contrib/ contrib/mod_defender/spoa.c | 8 +- contrib/mod_defender/standalone.c | 18 +- contrib/modsecurity/spoa.c | 8 +- .../prometheus-exporter/service-prometheus.c | 12 +- contrib/spoa_example/spoa.c | 8 +- include/haproxy/action.h | 2 +- include/haproxy/protobuf.h | 28 +- src/acl.c | 6 +- src/action.c | 4 +- src/auth.c | 8 +- src/backend.c | 26 +- src/cache.c | 8 +- src/cfgparse-global.c | 152 ++++----- src/cfgparse-listen.c | 306 +++++++++--------- src/cfgparse-ssl.c | 40 +-- src/cfgparse.c | 38 +-- src/cli.c | 38 +-- src/compression.c | 2 +- src/dns.c | 6 +- src/fcgi-app.c | 34 +- src/filters.c | 2 +- src/flt_http_comp.c | 6 +- src/flt_spoe.c | 110 +++---- src/flt_trace.c | 12 +- src/haproxy.c | 2 +- src/hlua.c | 2 +- src/http_act.c | 4 +- src/http_htx.c | 4 +- src/http_rules.c | 4 +- src/log.c | 12 +- src/mux_h1.c | 2 +- src/mworker-prog.c | 14 +- src/peers.c | 2 +- src/proxy.c | 76 ++--- src/sample.c | 2 +- src/server.c | 114 +++---- src/ssl_ckch.c | 6 +- src/ssl_crtlist.c | 4 +- src/ssl_sock.c | 2 +- src/stats.c | 8 +- src/stick_table.c | 2 +- src/tcp_act.c | 8 +- src/tcp_rules.c | 6 +- src/uri_auth.c | 4 +- 44 files changed, 580 insertions(+), 580 deletions(-) -- 2.29.0
