чт, 7 окт. 2021 г. в 10:58, Willy Tarreau <[email protected]>: > Hi Ilya, > > On Wed, Oct 06, 2021 at 11:26:13PM +0500, Ilya Shipitsin wrote: > > +/* ERR_func_error_string is deprecated in OpenSSL-3.0.0 */ > > +#if (OPENSSL_VERSION_NUMBER >= 0x30000000L) > > +#define HA_ERR_func_error_string(ret) "OPENSSL_internal" > > +#else > > +#define HA_ERR_func_error_string(ret) ERR_func_error_string(ret) > > +#endif > > Just thinking about something, given that the new API was already adopted > by BoringSSL and will probably be at some point in time by LibreSSL, would > it not be better to have a single macro "HA_SSL_USE_API_V3" or something > like this that we set based on the various libs' versions, and rely on this > one for all other defines ? I think it could significantly simplify the > porting to other libs and avoid a real mess with version numbers > everywhere. >
even BoringSSL states "it adopted upstream changes", it is different in details, for example ERR_func_error_string is not deprecated in BoringSSL. Well, there might be a common divisor of course. I'll keep an eye on it :) as for this particular patch, it is openssl specific (at least now) > > Just my two cents, > Willy >
