Hello,

when OPENSSL_VERSION=latest (same for LIBRESSL_VERSION=latest) was
introduced, I made a mistake, and resolved version was generated as
OPENSSL=3.0.5 which makes no sense to build-ssl.sh, proper version should
have been OPENSSL_VERSION=3.0.5

temporarily we stick to LIBRESSL=3.5.3, because of few rergressions in
recently released 3.6.0

cheers,
Ilya
From 4298e0251a08649dd650294a2bdd1bb700f38e42 Mon Sep 17 00:00:00 2001
From: Ilya Shipitsin <chipits...@gmail.com>
Date: Sat, 8 Oct 2022 20:00:41 +0500
Subject: [PATCH] CI: SSL: use proper version generating when "latest" semantic
 is used

both "OPENSSL_VERSION=latest" and "LIBRESSL_VERSION=latest" processing
introduced errors when build-ssl.sh script was invoked. that error
in turn led to skipping custom openssl build and haproxy was linked against
stock openssl, i.e. openssl-1.1.1

also, we temporarily stick to LibreSSL=3.5.3, because recently released
3.6.0 introduced some regression which must be resolved first
---
 .github/matrix.py | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/.github/matrix.py b/.github/matrix.py
index 6282767fe..19ae87d79 100755
--- a/.github/matrix.py
+++ b/.github/matrix.py
@@ -42,7 +42,7 @@ def determine_latest_openssl(ssl):
         if "openssl-" in name:
             if name > latest_tag:
                latest_tag = name
-    return "OPENSSL={}".format(latest_tag[8:])
+    return "OPENSSL_VERSION={}".format(latest_tag[8:])
 
 def determine_latest_libressl(ssl):
     libressl_download_list = urllib.request.urlopen("http://ftp.openbsd.org/pub/OpenBSD/LibreSSL/";)
@@ -50,7 +50,7 @@ def determine_latest_libressl(ssl):
         decoded_line = line.decode("utf-8")
         if "libressl-" in decoded_line and ".tar.gz.asc" in decoded_line:
              l = re.split("libressl-|.tar.gz.asc", decoded_line)[1]
-    return "LIBRESSL={}".format(l)
+    return "LIBRESSL_VERSION={}".format(l)
 
 def clean_compression(compression):
     return compression.replace("USE_", "").lower()
@@ -128,7 +128,7 @@ for CC in ["gcc", "clang"]:
         "stock",
         "OPENSSL_VERSION=1.0.2u",
         "OPENSSL_VERSION=latest",
-        "LIBRESSL_VERSION=latest",
+        "LIBRESSL_VERSION=3.5.3",
         "QUICTLS=yes",
 #        "BORINGSSL=yes",
     ]:
-- 
2.37.3

Reply via email to