Sure, it would be fine to add this; there is also a for-loop in one spot that doesn't compile in Visual Studio because it declares an enum inline, so one has to move the enum.
But these things don't matter, they only take a minute to fix. It's trivial. Whereas getting the library to build and link for the first time is measured in hours. It is a two-orders-of-magnitude difference, which is why I am saying that if widespread use of the code is a goal, making it easier to build should be the priority. On Tuesday, December 15, 2015, Behdad Esfahbod <[email protected]> wrote: > On 15-12-13 09:33 PM, Jamie Dale wrote: > > You'll need a define to stub out getenv for a PS4 build > > I'll take a patch to hb-private.hh to do that. >
_______________________________________________ HarfBuzz mailing list [email protected] http://lists.freedesktop.org/mailman/listinfo/harfbuzz
