Rana Dasgupta wrote: > On 6/26/06, Geir Magnusson Jr <[EMAIL PROTECTED]> wrote: >> >> >Odd. It was broken for me too. What changed? >> >> >I applied the patch - thanks. > > > To determine this, one would have to roll back the last commit and retry > the build + smoke tests. And traverse back till we identify what broke it. > We could also consider requesting the patches that came after this to be > resubmitted. At least.
That would be the long way. The short way would be just to look at the svn log and make an educated guess. > It may help to start putting in some submission citeria for patches eg., a > successful log from the existing drlvm smoke tests etc. Patches, though not > big, are coming in quite rapidly and it can't be easy for committers to > verify everything on two target platforms. That has been our criteria - make sure the tests pass on both platforms. > Also, the existing few smoke tests will not catch all bugs. At some point, > new tests should accompany non trivial submissions. We don't want to get > into a situation where we have a serious breakage. We ask that every patch we get be accompanied by a testcase, but that isn't always possible. > It will be good to know how we are doing the corresponding stuff in the > classlibs. > --------------------------------------------------------------------- Terms of use : http://incubator.apache.org/harmony/mailing.html To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
