On 10/6/06, Mark Hindess <[EMAIL PROTECTED]> wrote:
On 6 October 2006 at 9:57, Tim Ellison <[EMAIL PROTECTED]> wrote: > Mark beat me to it, so you are in good hands. And slightly regretting it... it's a big patch and one that's worth being careful with ... mixing up messages would be very confusing. It is interesting to note that many of the messages are for logging and output to the console. > When it comes to some of the other big modules you could do it > incrementally, i.e. submit patches that migrate packages to the new > framework; they should work fine in parallel during the transition. Agreed. That might make it easier to check the patches too.
Also agree with you guys. Last modules (except misc and tools) have huge number of messages and it is a real help to have a number of patches instead of one(e.g devided by packages). It is easier for committers and for developers as well. However there is messages.properties file, that is common for all these patches. Applying this file for every sub-patch I suppose will rise snv conflict. Committers who are going to apply these patches should take this into account and be ready to resolve such conflicts every time:)
> Keep up the good work. Yes. These must be even more painful to generate than they are too read. Many thanks for doing this. I've spotted a couple of minor issues reading the patch[0] but I'll probably submit it as is unless I spot anything serious and fix them in a later commit.
Mark, good catch! I fixed some of these minor issues during preparing this patch, unfortunately there left few of them I'd missed. Regards, Ilya.
Regards, Mark. [0] Such as rmi.log.8D which is only used in an exception not a logging call. I wouldn't want this to break if/when Tim removes the logging. > Ilya Okomin wrote: > > Hi committers! > > > > Could someone look into the patch with [rmi] internationalization > > HARMONY-1317? > > Patch affects many source files and it would be great to apply it ASAP (if > > it is OK of course:)) to avoid conflicts with another changes in the > > Harmony > > svn. > > > > Thanks, > > Ilya. > > > > > > On 10/4/06, Ilya Okomin (JIRA) <[EMAIL PROTECTED]> wrote: > >> > >> [ http://issues.apache.org/jira/browse/HARMONY-1317?page=all ] > >> > >> Ilya Okomin updated HARMONY-1317: > >> --------------------------------- > >> > >> Attachment: rmi.diff > >> > >> Wow, it was really hard work! > >> Please try this patch. > >> > >> > [classlib][internationalization]Internationalization of the rmi module > >> > ---------------------------------------------------------------------- > >> > > >> > Key: HARMONY-1317 > >> > URL: http://issues.apache.org/jira/browse/HARMONY-1317 > >> > Project: Harmony > >> > Issue Type: Sub-task > >> > Components: Classlib > >> > Reporter: Ilya Okomin > >> > Priority: Trivial > >> > Attachments: rmi.diff > >> > > >> > > >> > [rmi] module should be internationalized with the scheme suggested in > >> HARMONY-1308 issue [1]. > >> > [1] http://issues.apache.org/jira/browse/HARMONY-1308 > >> > >> -- > >> This message is automatically generated by JIRA. > >> - > >> If you think it was sent incorrectly contact one of the administrators: > >> http://issues.apache.org/jira/secure/Administrators.jspa > >> - > >> For more information on JIRA, see: http://www.atlassian.com/software/jira > >> > >> > >> > > > > > > -- > > Tim Ellison ([EMAIL PROTECTED]) > IBM Java technology centre, UK. > > --------------------------------------------------------------------- > Terms of use : http://incubator.apache.org/harmony/mailing.html > To unsubscribe, e-mail: [EMAIL PROTECTED] > For additional commands, e-mail: [EMAIL PROTECTED] > --------------------------------------------------------------------- Terms of use : http://incubator.apache.org/harmony/mailing.html To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
-- -- Ilya Okomin Intel Middleware Products Division
