On 26 October 2006 at 19:16, "Tony Wu" <[EMAIL PROTECTED]> wrote: > I have scratched out the stand alone rules, > > should use assertNull, assertEquals\s*\((.*,\s*null\s*|\s*null\s*,.*)\)\s*; > should use assertFalse, assertEquals\s*\((.*,\s*false\s*|\s*false\s*,.*)\)\s* > ; > should use assertTrue, assertEquals\s*\((.*,\s*true\s*|\s*true\s*,.*)\)\s*; > last argument should not be a constant, > assertEquals\s*\(.*,\s*("[^"]*"|'[^']'|[+-]?\d+[0-9a-fA-FLlPp]*|[A-Z_]*)\s*\) > \s*; > always true/false, assert(False|True)\s*\(\s*(false|true)\s*\)\s*; > multiple assertion, assertTrue\s*\(.*\&\&.*\)\s*; > multiple assertion, assertFalse\s*\(.*\|\|.*\)\s*; > should use assertNull, assertTrue\s*\((.*==\s*null\s*|\s*null\s*==.*)\)\s*; > should use assertTrue, assertTrue\s*\((.*==\s*true\s*|\s*true\s*==.*)\)\s*; > should use assertFalse, assertTrue\s*\((.*==\s*false\s*|\s*false\s*==.*)\)\s* > ; > should use assertNotNull, assertTrue\s*\((.*!=\s*null\s*|\s*null\s*!=.*)\)\s* > ; > should use assertFalse, assertTrue\s*\((.*!=\s*true\s*|\s*true\s*!=.*)\)\s*; > should use assertTrue, assertTrue\s*\((.*!=\s*false\s*|\s*false\s*!=.*)\)\s*; > should use assertFalse, assertTrue\s*\(\s*!.*\)\s*; > should use assertFalse, assertTrue\s*\("[^"]*"\s*,\s*!.*\)\s*; > should use assertNotNull, assertFalse\s*\((.*==\s*null\s*|\s*null\s*==.*)\)\s > *; > should use assertFalse, assertFalse\s*\((.*!=\s*true\s*|\s*true\s*!=.*)\)\s*; > should use assertTrue, assertFalse\s*\((.*!=\s*false\s*|\s*false\s*!=.*)\)\s* > ; > should use assertNull, assertFalse\s*\((.*!=\s*null\s*|\s*null\s*!=.*)\)\s*; > should use assertFalse, assertFalse\s*\((.*==\s*true\s*|\s*true\s*==.*)\)\s*; > should use assertTrue, assertFalse\s*\((.*==\s*false\s*|\s*false\s*==.*)\)\s* > ; > should use assertEquals, assertTrue\s*\(.*==.*\)\s*; > should use assertEquals, assertTrue\s*\(.*\.euqals.*\)\s*;
There's a typo in that last one. But be careful with these. For example, the second last rule will match things like: modules/luni/src/test/java/tests/api/java/io/BufferedInputStreamTest.java: assertTrue("Wrong bytes", in.read() == 6 && in.read() == 7); which is why the regular expressions in my script are a little stricter (that is not using .* but a character class to avoid catching complex cases). > any comments? If you fix any automatically, please check them over manual unless you are really, really sure the fixes are not breaking anything. Regards, Mark.