Geir,
I also thought about additional cmd-line param to compile and link
Jitrino.dll with tests. I hope we will have a lot of tests in future, so IMO
it's a good idea to separate it from default Jitrino build.
I'll try to provide this switch with the next patch and that could be a good
time to add framework into the trunk.
Another issue is how to run the tests. I added 'junit_integration' into the
patch - so we already have a solution.
On 10/27/06, Geir Magnusson Jr. <[EMAIL PROTECTED]> wrote:
While you're at it, I'd like to get this patches in, but we probably
need a new target for building, as running normally with this framework
compiled in leads to problems.
Can we find a way to make it a different build target, or at least a flag
-Dwith.jitrino.test.framework
or something?
(Apologies if you've already done that :)
geir
Mikhail Fursov wrote:
> Thank you Ivan.
> The problem you found with TestRegistry.cpp will be fixed with the next
my
> patch for Jitrino testing framework.
> I'll check all of your tests this weekend and post comments.
>
> On 10/27/06, Ivan Kollegov <[EMAIL PROTECTED]> wrote:
>>
>> Hi JIT developers.
>>
>> I've wrote 4 templates and about 20 tests to test Jitrino's internal
>> algorithms. I put them all into JIRA-1586
>>
>> Also I've founded a problem with testing simplifier.cpp (test
>> testSimplifyIf). The problem was in
>>
>> FlowGraph::foldBranch(ControlFlowGraph& fg, Node* block, BranchInst*
>> br, bool isTaken)
>>
>> {
>> assert(br == block->getLastInst());
>> assert(block->getOutDegree() == 2);
>> fg.removeEdge(block->getOutEdge(isTaken ? Edge::Kind_False :
>> Edge::Kind_True));
>> br->unlink();
>> }
>>
>> The variable "block" can be null. This problem can be fixed with patch
>> in JIRA-1986
>>
>> Also, I had problems with race condition with initializing of static
>> section in TestRegistry* TestRegistry::getInstance(){
>>
>> Could you check the changes?
>>
>
>
>
--
Mikhail Fursov
