[
https://issues.apache.org/jira/browse/HBASE-1841?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12776679#action_12776679
]
stack commented on HBASE-1841:
------------------------------
Thanks for working on this Schubert.
On the first patch, step 1, if key is same as last, do not make a new block.
AND if we keep getting the same key and current block is 2*blocksize, throw an
exception?
If so, I think you should just let the block run rather than throw an
exception... let it grow.
Also, does the keyComp have to be a data member? Can it be scoped within the
key append perhaps passed into checkBlockBoundary?
Review of second patch coming up....
> If multiple of same key in an hfile and they span blocks, may miss the
> earlier keys on a lookup
> -----------------------------------------------------------------------------------------------
>
> Key: HBASE-1841
> URL: https://issues.apache.org/jira/browse/HBASE-1841
> Project: Hadoop HBase
> Issue Type: Bug
> Reporter: stack
> Attachments: HBASE-1841-step1.patch, HBASE-1841-step2.patch
>
>
> See HBASE-818 for description by Schubert Zhang -- discovered by him doing a
> code review of hfile.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
