[
https://issues.apache.org/jira/browse/HBASE-1841?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12776699#action_12776699
]
ryan rawson commented on HBASE-1841:
------------------------------------
My review of step1:
- dont throw that exception for reasons stated above. We are opening ourselves
up to a hbase cluster that is unfixable.
- using a member variable for keyComp isn't really ideal - the state doesn't
last the length of the object (which is what that implies), and it very
temporary. A boolean to the checkBlockBoundary(boolean sameKey) would be
better. Or why even call checkBlockBoundary if the key is the same?
> If multiple of same key in an hfile and they span blocks, may miss the
> earlier keys on a lookup
> -----------------------------------------------------------------------------------------------
>
> Key: HBASE-1841
> URL: https://issues.apache.org/jira/browse/HBASE-1841
> Project: Hadoop HBase
> Issue Type: Bug
> Reporter: stack
> Attachments: HBASE-1841-step1.patch, HBASE-1841-step2.patch
>
>
> See HBASE-818 for description by Schubert Zhang -- discovered by him doing a
> code review of hfile.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
