----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/2811/#review4188 -----------------------------------------------------------
Ship it! Looks good to me. With our without the changes below I think this is fine. /trunk/src/java/org/apache/hcatalog/mapreduce/HCatTableSnapshot.java <https://reviews.apache.org/r/2811/#comment9440> I would put DB before Table to be more consistent with the cli (mydb.mytable) /trunk/src/java/org/apache/hcatalog/mapreduce/HCatTableSnapshot.java <https://reviews.apache.org/r/2811/#comment9441> I would put DB before Table to be more consistent with the CLi. - David On 2011-12-22 00:56:38, Vandana Ayyalasomayajula wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/2811/ > ----------------------------------------------------------- > > (Updated 2011-12-22 00:56:38) > > > Review request for hcatalog, Francis Liu and David Capwell. > > > Summary > ------- > > This class defines a snapshot for HCatalog tables. This is required in > Hcatalog map reduce package for revision management. > > > This addresses bug hcatalog-193. > https://issues.apache.org/jira/browse/hcatalog-193 > > > Diffs > ----- > > /trunk/src/java/org/apache/hcatalog/mapreduce/HCatTableSnapshot.java > PRE-CREATION > > Diff: https://reviews.apache.org/r/2811/diff > > > Testing > ------- > > The test case in HBase storage drivers covers this class. The unit tests > pass. > > > Thanks, > > Vandana > >
