----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/2811/#review4428 -----------------------------------------------------------
/trunk/storage-drivers/hbase/src/java/org/apache/hcatalog/hbase/HCatTableSnapshot.java <https://reviews.apache.org/r/2811/#comment9938> As previously discussed we want this object to be opaque. So can you make constructor, getRevision, containsColumn into package-private? - Francis On 2012-01-14 01:09:59, Vandana Ayyalasomayajula wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/2811/ > ----------------------------------------------------------- > > (Updated 2012-01-14 01:09:59) > > > Review request for hcatalog, Francis Liu and David Capwell. > > > Summary > ------- > > This class defines a snapshot for HCatalog tables. This is required in > Hcatalog map reduce package for revision management. > > > This addresses bug hcatalog-193. > https://issues.apache.org/jira/browse/hcatalog-193 > > > Diffs > ----- > > > /trunk/storage-drivers/hbase/src/java/org/apache/hcatalog/hbase/HCatTableSnapshot.java > PRE-CREATION > > Diff: https://reviews.apache.org/r/2811/diff > > > Testing > ------- > > The test case in HBase storage drivers covers this class. The unit tests > pass. > > > Thanks, > > Vandana > >
