[
https://issues.apache.org/jira/browse/HCATALOG-239?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13209990#comment-13209990
]
[email protected] commented on HCATALOG-239:
--------------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3901/#review5181
-----------------------------------------------------------
trunk/src/java/org/apache/hcatalog/common/HCatUtil.java
<https://reviews.apache.org/r/3901/#comment11344>
Still seems to be in HCatUtil. Do I have to use another patch to see this
change?
trunk/src/java/org/apache/hcatalog/common/HCatUtil.java
<https://reviews.apache.org/r/3901/#comment11348>
Removed.
trunk/src/java/org/apache/hcatalog/common/HCatUtil.java
<https://reviews.apache.org/r/3901/#comment11350>
Discussed with Alan about this. If we leave it as an empty constructor,
this loads the HiveClient class. Alan was of the opinion that the class does
not really matter. So have changed this to be the empty constructor. We can use
another if the need arises.
trunk/src/java/org/apache/hcatalog/common/HCatUtil.java
<https://reviews.apache.org/r/3901/#comment11351>
Fixed as part of Sushanth's changes?
trunk/src/java/org/apache/hcatalog/common/HCatUtil.java
<https://reviews.apache.org/r/3901/#comment11352>
true.
trunk/src/java/org/apache/hcatalog/mapreduce/HCatBaseInputFormat.java
<https://reviews.apache.org/r/3901/#comment11353>
Done.
trunk/src/java/org/apache/hcatalog/mapreduce/HCatBaseInputFormat.java
<https://reviews.apache.org/r/3901/#comment11354>
Done.
trunk/src/java/org/apache/hcatalog/mapreduce/HCatBaseInputFormat.java
<https://reviews.apache.org/r/3901/#comment11355>
Done. Both.
trunk/src/java/org/apache/hcatalog/mapreduce/HCatBaseInputFormat.java
<https://reviews.apache.org/r/3901/#comment11357>
Fixed as part of the exception being thrown from getJobInfo.
trunk/src/java/org/apache/hcatalog/mapreduce/HCatBaseInputFormat.java
<https://reviews.apache.org/r/3901/#comment11361>
Done.
trunk/src/java/org/apache/hcatalog/mapreduce/HCatRecordReader.java
<https://reviews.apache.org/r/3901/#comment11362>
The input split that is passed to the mapreduce initialize has to be the
mapreduce inputsplit by definition. Added this new initialize function as an
imitation. Can rename the function but it is doing the functionality of
initialize.
trunk/src/java/org/apache/hcatalog/mapreduce/HCatRecordReader.java
<https://reviews.apache.org/r/3901/#comment11363>
Done.
trunk/src/java/org/apache/hcatalog/mapreduce/HCatRecordReader.java
<https://reviews.apache.org/r/3901/#comment11364>
Done.
- Vikram
On 2012-02-14 22:21:47, Vikram Dixit Kumaraswamy wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/3901/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2012-02-14 22:21:47)
bq.
bq.
bq. Review request for Alan Gates, Sushanth Sowmyan and Francis Liu.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. This is a patch with input format specific changes integrated with record
reader and output format changes.
bq.
bq.
bq. This addresses bug HCATALOG-239.
bq. https://issues.apache.org/jira/browse/HCATALOG-239
bq.
bq.
bq. Diffs
bq. -----
bq.
bq. trunk/src/java/org/apache/hcatalog/common/HCatUtil.java 1241662
bq. trunk/src/java/org/apache/hcatalog/mapreduce/HCatBaseInputFormat.java
1241662
bq. trunk/src/java/org/apache/hcatalog/mapreduce/HCatEximInputFormat.java
1241662
bq. trunk/src/java/org/apache/hcatalog/mapreduce/HCatInputFormat.java
1241662
bq. trunk/src/java/org/apache/hcatalog/mapreduce/HCatRecordReader.java
1241662
bq. trunk/src/java/org/apache/hcatalog/mapreduce/HCatSplit.java 1241662
bq. trunk/src/java/org/apache/hcatalog/mapreduce/HCatSplit.java 1241662
bq.
bq. Diff: https://reviews.apache.org/r/3901/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq.
bq. Thanks,
bq.
bq. Vikram
bq.
bq.
> Changes to HCatInputFormat to make it use SerDes instead of StorageDrivers
> --------------------------------------------------------------------------
>
> Key: HCATALOG-239
> URL: https://issues.apache.org/jira/browse/HCATALOG-239
> Project: HCatalog
> Issue Type: Sub-task
> Components: storage handlers
> Affects Versions: 0.4
> Reporter: Alan Gates
> Assignee: Vikram Dixit K
> Fix For: 0.4
>
> Attachments: 239.patch, 239_1.patch, 239_2.patch, 239_3.patch,
> 239_4.patch
>
>
> This JIRA covers changes to HCatInputFormat and InputJobInfo. See
> HCATALOG-237 for details and design notes.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
