[ 
https://issues.apache.org/jira/browse/HCATALOG-239?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13215219#comment-13215219
 ] 

[email protected] commented on HCATALOG-239:
--------------------------------------------------------


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3945/#review5316
-----------------------------------------------------------



trunk/src/test/org/apache/hcatalog/data/TestLazyHCatRecord.java
<https://reviews.apache.org/r/3945/#comment11568>

    comma needed here.



trunk/src/test/org/apache/hcatalog/data/TestLazyHCatRecord.java
<https://reviews.apache.org/r/3945/#comment11567>

    Replace this line with :
    
    HCatSchema schema = 
HCatSchemaUtils.getHCatSchema(ti).get(0).getStructSubSchema();
    
    And this test will work. Basically, it's the difference between the 
following schemas:
    
    earlier: struct<an_int:int,a_long:bigint,a_double:double,a_string:string>
    now : an_int:int,a_long:bigint,a_double:double,a_string:string
    
    



trunk/src/test/org/apache/hcatalog/data/TestLazyHCatRecord.java
<https://reviews.apache.org/r/3945/#comment11570>

    comma needed here



trunk/src/test/org/apache/hcatalog/data/TestLazyHCatRecord.java
<https://reviews.apache.org/r/3945/#comment11569>

    Replace this line with :
    
    HCatSchema schema = 
HCatSchemaUtils.getHCatSchema(ti).get(0).getStructSubSchema();
    
    And this test will work. Basically, it's the difference between the 
following schemas:
    
    earlier: struct<an_int:int,a_long:bigint,a_double:double,a_string:string>
    now : an_int:int,a_long:bigint,a_double:double,a_string:string
    


- Sushanth


On 2012-02-23 19:27:43, Vikram Dixit Kumaraswamy wrote:
bq.  
bq.  -----------------------------------------------------------
bq.  This is an automatically generated e-mail. To reply, visit:
bq.  https://reviews.apache.org/r/3945/
bq.  -----------------------------------------------------------
bq.  
bq.  (Updated 2012-02-23 19:27:43)
bq.  
bq.  
bq.  Review request for Sushanth Sowmyan and Francis Liu.
bq.  
bq.  
bq.  Summary
bq.  -------
bq.  
bq.  Incorporated Francis' comments.
bq.  
bq.  
bq.  This addresses bug HCATALOG-239.
bq.      https://issues.apache.org/jira/browse/HCATALOG-239
bq.  
bq.  
bq.  Diffs
bq.  -----
bq.  
bq.    trunk/src/java/org/apache/hcatalog/common/ErrorType.java 1292521 
bq.    trunk/src/java/org/apache/hcatalog/common/HCatUtil.java 1292521 
bq.    trunk/src/java/org/apache/hcatalog/data/DataType.java 1292521 
bq.    
trunk/src/java/org/apache/hcatalog/data/HCatRecordObjectInspectorFactory.java 
1292521 
bq.    trunk/src/java/org/apache/hcatalog/data/LazyHCatRecord.java 1292521 
bq.    
trunk/src/java/org/apache/hcatalog/mapreduce/DefaultOutputCommitterContainer.java
 1292521 
bq.    
trunk/src/java/org/apache/hcatalog/mapreduce/FileOutputCommitterContainer.java 
1292521 
bq.    
trunk/src/java/org/apache/hcatalog/mapreduce/FileOutputFormatContainer.java 
1292521 
bq.    trunk/src/java/org/apache/hcatalog/mapreduce/FosterStorageHandler.java 
1292521 
bq.    trunk/src/java/org/apache/hcatalog/mapreduce/HCatBaseInputFormat.java 
1292521 
bq.    trunk/src/java/org/apache/hcatalog/mapreduce/HCatBaseOutputFormat.java 
1292521 
bq.    trunk/src/java/org/apache/hcatalog/mapreduce/HCatOutputFormat.java 
1292521 
bq.    trunk/src/java/org/apache/hcatalog/mapreduce/HCatRecordReader.java 
1292521 
bq.    trunk/src/java/org/apache/hcatalog/mapreduce/HCatSplit.java 1292521 
bq.    trunk/src/java/org/apache/hcatalog/mapreduce/HCatTableInfo.java 1292521 
bq.    trunk/src/java/org/apache/hcatalog/mapreduce/InitializeInput.java 
1292521 
bq.    trunk/src/java/org/apache/hcatalog/mapreduce/InputJobInfo.java 1292521 
bq.    trunk/src/java/org/apache/hcatalog/mapreduce/InternalUtil.java 1292521 
bq.    trunk/src/java/org/apache/hcatalog/mapreduce/PartInfo.java 1292521 
bq.    trunk/src/java/org/apache/hcatalog/pig/HCatLoader.java 1292521 
bq.    trunk/src/test/org/apache/hcatalog/data/TestHCatRecordSerDe.java 1292521 
bq.    trunk/src/test/org/apache/hcatalog/data/TestLazyHCatRecord.java 1292521 
bq.    
trunk/src/test/org/apache/hcatalog/mapreduce/TestHCatHiveCompatibility.java 
1292521 
bq.    trunk/src/test/org/apache/hcatalog/pig/TestHCatLoaderComplexSchema.java 
1292521 
bq.  
bq.  Diff: https://reviews.apache.org/r/3945/diff
bq.  
bq.  
bq.  Testing
bq.  -------
bq.  
bq.  
bq.  Thanks,
bq.  
bq.  Vikram
bq.  
bq.


                
> Changes to HCatInputFormat to make it use SerDes instead of StorageDrivers
> --------------------------------------------------------------------------
>
>                 Key: HCATALOG-239
>                 URL: https://issues.apache.org/jira/browse/HCATALOG-239
>             Project: HCatalog
>          Issue Type: Sub-task
>          Components: storage handlers
>    Affects Versions: 0.4
>            Reporter: Alan Gates
>            Assignee: Vikram Dixit K
>             Fix For: 0.4
>
>         Attachments: 239.patch, 239_1.patch, 239_2.patch, 239_3.patch, 
> 239_4.patch, 239_5.patch, 239_6.patch
>
>
> This JIRA covers changes to HCatInputFormat and InputJobInfo.  See 
> HCATALOG-237 for details and design notes.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to