[
https://issues.apache.org/jira/browse/HCATALOG-239?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13215452#comment-13215452
]
[email protected] commented on HCATALOG-239:
--------------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3945/#review5313
-----------------------------------------------------------
trunk/src/java/org/apache/hcatalog/common/HCatUtil.java
<https://reviews.apache.org/r/3945/#comment11582>
Shouldn't this be stored in OutputJobInfo. This could be troublesome if you
have multiple stores put in the same same pig MR Job?
trunk/src/java/org/apache/hcatalog/common/HCatUtil.java
<https://reviews.apache.org/r/3945/#comment11558>
since you're just rethrowing might as well not catch the exception.
trunk/src/java/org/apache/hcatalog/common/HCatUtil.java
<https://reviews.apache.org/r/3945/#comment11559>
clean up unused code.
trunk/src/java/org/apache/hcatalog/common/HCatUtil.java
<https://reviews.apache.org/r/3945/#comment11581>
curly brackets should be at the end of the method.
trunk/src/java/org/apache/hcatalog/data/LazyHCatRecord.java
<https://reviews.apache.org/r/3945/#comment11574>
Does it really ahve have to be throws exception? Can you be more specific?
trunk/src/java/org/apache/hcatalog/mapreduce/FosterStorageHandler.java
<https://reviews.apache.org/r/3945/#comment11580>
not sure why it has to be serializable?
trunk/src/java/org/apache/hcatalog/mapreduce/HCatBaseInputFormat.java
<https://reviews.apache.org/r/3945/#comment11583>
We should prolly move this into InputJobInfo. If we can't do the refactor
here please add a TODO.
trunk/src/java/org/apache/hcatalog/mapreduce/HCatBaseInputFormat.java
<https://reviews.apache.org/r/3945/#comment11592>
is this used?
trunk/src/java/org/apache/hcatalog/mapreduce/HCatBaseInputFormat.java
<https://reviews.apache.org/r/3945/#comment11602>
This doesn't look right, with this the current conf, partinfo will get the
location of the previous partinfo? You really should put this in
configureInput, that way partInto.jobProperties would've been set with the
correct input locaiton prior to this.
trunk/src/java/org/apache/hcatalog/mapreduce/HCatBaseInputFormat.java
<https://reviews.apache.org/r/3945/#comment11593>
jobConf must be copied back to JobContext.
trunk/src/java/org/apache/hcatalog/mapreduce/HCatBaseInputFormat.java
<https://reviews.apache.org/r/3945/#comment11589>
you don't need the cast?
trunk/src/java/org/apache/hcatalog/mapreduce/HCatBaseInputFormat.java
<https://reviews.apache.org/r/3945/#comment11590>
remove unused code.
trunk/src/java/org/apache/hcatalog/mapreduce/HCatBaseInputFormat.java
<https://reviews.apache.org/r/3945/#comment11594>
Why not use ReflectionUtils?
trunk/src/java/org/apache/hcatalog/mapreduce/HCatBaseInputFormat.java
<https://reviews.apache.org/r/3945/#comment11586>
As I've mentioned before, this should go into
FosterStorageHandler.configureInputJobProperties()
trunk/src/java/org/apache/hcatalog/mapreduce/HCatOutputFormat.java
<https://reviews.apache.org/r/3945/#comment11591>
I don't see why these have to be coming from hcatUtil instead of take from
the conf?
trunk/src/java/org/apache/hcatalog/mapreduce/HCatRecordReader.java
<https://reviews.apache.org/r/3945/#comment11595>
update comment
trunk/src/java/org/apache/hcatalog/mapreduce/HCatRecordReader.java
<https://reviews.apache.org/r/3945/#comment11597>
be more specific?
trunk/src/java/org/apache/hcatalog/mapreduce/HCatRecordReader.java
<https://reviews.apache.org/r/3945/#comment11596>
message?
trunk/src/java/org/apache/hcatalog/mapreduce/HCatSplit.java
<https://reviews.apache.org/r/3945/#comment11598>
curly bracket should be after method.
trunk/src/java/org/apache/hcatalog/mapreduce/InitializeInput.java
<https://reviews.apache.org/r/3945/#comment11600>
does this have to be public?
trunk/src/java/org/apache/hcatalog/mapreduce/InitializeInput.java
<https://reviews.apache.org/r/3945/#comment11599>
Message, IllegalStateException would be better
trunk/src/java/org/apache/hcatalog/mapreduce/InitializeInput.java
<https://reviews.apache.org/r/3945/#comment11601>
This seems simple enough not to need a method?
- Francis
On 2012-02-24 03:32:30, Vikram Dixit Kumaraswamy wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/3945/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2012-02-24 03:32:30)
bq.
bq.
bq. Review request for Sushanth Sowmyan and Francis Liu.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. Incorporated Francis' comments.
bq.
bq.
bq. This addresses bug HCATALOG-239.
bq. https://issues.apache.org/jira/browse/HCATALOG-239
bq.
bq.
bq. Diffs
bq. -----
bq.
bq. trunk/src/java/org/apache/hcatalog/common/ErrorType.java 1292521
bq. trunk/src/java/org/apache/hcatalog/common/HCatUtil.java 1292521
bq. trunk/src/java/org/apache/hcatalog/data/DataType.java 1292521
bq.
trunk/src/java/org/apache/hcatalog/data/HCatRecordObjectInspectorFactory.java
1292521
bq. trunk/src/java/org/apache/hcatalog/data/LazyHCatRecord.java 1292521
bq.
trunk/src/java/org/apache/hcatalog/mapreduce/DefaultOutputCommitterContainer.java
1292521
bq.
trunk/src/java/org/apache/hcatalog/mapreduce/FileOutputCommitterContainer.java
1292521
bq.
trunk/src/java/org/apache/hcatalog/mapreduce/FileOutputFormatContainer.java
1292521
bq. trunk/src/java/org/apache/hcatalog/mapreduce/FosterStorageHandler.java
1292521
bq. trunk/src/java/org/apache/hcatalog/mapreduce/HCatBaseInputFormat.java
1292521
bq. trunk/src/java/org/apache/hcatalog/mapreduce/HCatBaseOutputFormat.java
1292521
bq. trunk/src/java/org/apache/hcatalog/mapreduce/HCatOutputFormat.java
1292521
bq. trunk/src/java/org/apache/hcatalog/mapreduce/HCatRecordReader.java
1292521
bq. trunk/src/java/org/apache/hcatalog/mapreduce/HCatSplit.java 1292521
bq. trunk/src/java/org/apache/hcatalog/mapreduce/HCatTableInfo.java 1292521
bq. trunk/src/java/org/apache/hcatalog/mapreduce/InitializeInput.java
1292521
bq. trunk/src/java/org/apache/hcatalog/mapreduce/InputJobInfo.java 1292521
bq. trunk/src/java/org/apache/hcatalog/mapreduce/InternalUtil.java 1292521
bq. trunk/src/java/org/apache/hcatalog/mapreduce/PartInfo.java 1292521
bq. trunk/src/java/org/apache/hcatalog/pig/HCatLoader.java 1292521
bq. trunk/src/test/org/apache/hcatalog/data/TestHCatRecordSerDe.java 1292521
bq. trunk/src/test/org/apache/hcatalog/data/TestLazyHCatRecord.java 1292521
bq.
trunk/src/test/org/apache/hcatalog/mapreduce/TestHCatHiveCompatibility.java
1292521
bq. trunk/src/test/org/apache/hcatalog/pig/TestHCatLoaderComplexSchema.java
1292521
bq.
bq. Diff: https://reviews.apache.org/r/3945/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq.
bq. Thanks,
bq.
bq. Vikram
bq.
bq.
> Changes to HCatInputFormat to make it use SerDes instead of StorageDrivers
> --------------------------------------------------------------------------
>
> Key: HCATALOG-239
> URL: https://issues.apache.org/jira/browse/HCATALOG-239
> Project: HCatalog
> Issue Type: Sub-task
> Components: storage handlers
> Affects Versions: 0.4
> Reporter: Alan Gates
> Assignee: Vikram Dixit K
> Fix For: 0.4
>
> Attachments: 239.patch, 239_1.patch, 239_2.patch, 239_3.patch,
> 239_4.patch, 239_5.patch, 239_6.patch, 239_7.patch
>
>
> This JIRA covers changes to HCatInputFormat and InputJobInfo. See
> HCATALOG-237 for details and design notes.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
