> On 2012-04-16 19:58:16, Mithun Radhakrishnan wrote: > > /trunk/src/java/org/apache/hcatalog/common/HCatLogUtil.java, line 35 > > <https://reviews.apache.org/r/4732/diff/1/?file=102090#file102090line35> > > > > Question: Shouldn't we do > > > > logger.info(" " + data); > > > > instead of > > > > logger.info("{} ", data); > > > > Wouldn't this be far more performant?
The question is not really what is the fastest way of string concatenation, but what brings us the lower relevant cost of logging in the whole picture. I think this here would be a good starting point: http://www.slf4j.org/faq.html#logging_performance - Thomas ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4732/#review6950 ----------------------------------------------------------- On 2012-04-16 06:31:43, Vandana Ayyalasomayajula wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/4732/ > ----------------------------------------------------------- > > (Updated 2012-04-16 06:31:43) > > > Review request for hcatalog, Sushanth Sowmyan, Francis Liu, and Thomas. > > > Summary > ------- > > We need to do the following things: > > + Use log4j across the board > + Introduce a class with methods to help logging, refactoring away the bunch > of these functions in HCatUtil right now > + Instrument debug logging with isLogEnabled checks on the log level > + remove all instances of commented code whose purpose was for debug logs > > > This addresses bug hcatalog-68. > https://issues.apache.org/jira/browse/hcatalog-68 > > > Diffs > ----- > > /trunk/ivy.xml 1325838 > > /trunk/src/java/org/apache/hcatalog/cli/SemanticAnalysis/HCatSemanticAnalyzer.java > 1325838 > /trunk/src/java/org/apache/hcatalog/common/HCatLogUtil.java PRE-CREATION > /trunk/src/java/org/apache/hcatalog/common/HCatUtil.java 1325838 > > /trunk/src/java/org/apache/hcatalog/data/HCatRecordObjectInspectorFactory.java > 1325838 > /trunk/src/java/org/apache/hcatalog/data/HCatRecordSerDe.java 1325838 > /trunk/src/java/org/apache/hcatalog/data/JsonSerDe.java 1325838 > > /trunk/src/java/org/apache/hcatalog/mapreduce/DefaultOutputCommitterContainer.java > 1325838 > /trunk/src/java/org/apache/hcatalog/mapreduce/HCatOutputFormat.java 1325838 > /trunk/src/java/org/apache/hcatalog/mapreduce/HCatRecordReader.java 1325838 > /trunk/src/java/org/apache/hcatalog/mapreduce/HCatSplit.java 1325838 > /trunk/src/java/org/apache/hcatalog/mapreduce/InitializeInput.java 1325838 > /trunk/src/test/org/apache/hcatalog/data/HCatDataCheckUtil.java 1325838 > /trunk/src/test/org/apache/hcatalog/data/TestJsonSerDe.java 1325838 > > Diff: https://reviews.apache.org/r/4732/diff > > > Testing > ------- > > Unit tests pass. Log messages verified from test logs. > > > Thanks, > > Vandana > >
