-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4732/
-----------------------------------------------------------
(Updated 2012-04-16 21:16:58.722557)
Review request for hcatalog, Sushanth Sowmyan, Francis Liu, and Thomas.
Changes
-------
-- Added logger instances for every class. Deriving class names from stack
trace is messy, so decided to stick to having logger instance per class.
-- The utility class will be used only lists and maps.
-- switch from log4j to slf4j.
Summary
-------
We need to do the following things:
+ Use log4j across the board
+ Introduce a class with methods to help logging, refactoring away the bunch of
these functions in HCatUtil right now
+ Instrument debug logging with isLogEnabled checks on the log level
+ remove all instances of commented code whose purpose was for debug logs
This addresses bug hcatalog-68.
https://issues.apache.org/jira/browse/hcatalog-68
Diffs (updated)
-----
/trunk/src/java/org/apache/hcatalog/cli/SemanticAnalysis/HCatSemanticAnalyzer.java
1325838
/trunk/src/java/org/apache/hcatalog/common/HCatLogUtil.java PRE-CREATION
/trunk/src/java/org/apache/hcatalog/common/HCatUtil.java 1325838
/trunk/src/java/org/apache/hcatalog/data/HCatRecordObjectInspector.java
1325838
/trunk/src/java/org/apache/hcatalog/data/HCatRecordObjectInspectorFactory.java
1325838
/trunk/src/java/org/apache/hcatalog/data/HCatRecordSerDe.java 1325838
/trunk/src/java/org/apache/hcatalog/data/JsonSerDe.java 1325838
/trunk/src/java/org/apache/hcatalog/mapreduce/DefaultOutputCommitterContainer.java
1325838
/trunk/src/java/org/apache/hcatalog/mapreduce/HCatOutputFormat.java 1325838
/trunk/src/java/org/apache/hcatalog/mapreduce/HCatRecordReader.java 1325838
/trunk/src/java/org/apache/hcatalog/mapreduce/HCatSplit.java 1325838
/trunk/src/java/org/apache/hcatalog/mapreduce/InitializeInput.java 1325838
/trunk/src/test/org/apache/hcatalog/data/HCatDataCheckUtil.java 1325838
/trunk/src/test/org/apache/hcatalog/data/TestJsonSerDe.java 1325838
Diff: https://reviews.apache.org/r/4732/diff
Testing
-------
Unit tests pass. Log messages verified from test logs.
Thanks,
Vandana
