----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4921/#review7339 -----------------------------------------------------------
There are quite a few spacing issues, like maybe you're mixing tabs and spaces or something. The policy in HCat code is to use only spaces. trunk/src/java/org/apache/hcatalog/data/HCatRecord.java <https://reviews.apache.org/r/4921/#comment16193> "at the indicated position in the record" would be better than "at a specified index" trunk/src/java/org/apache/hcatalog/data/HCatRecord.java <https://reviews.apache.org/r/4921/#comment16194> Should note that after this call will copy the pointers to the data, not the data itself. Should also note that this call will obliterate anything currently in this record. trunk/src/java/org/apache/hcatalog/data/schema/HCatFieldSchema.java <https://reviews.apache.org/r/4921/#comment16195> What do the default values mean in this enum list? These look like the defaults from Java. But HCat/Hive doesn't have a notion of default values. The ranges are nice, we should remove the default values. trunk/src/java/org/apache/hcatalog/data/transfer/ReadEntity.java <https://reviews.apache.org/r/4921/#comment16196> Spacing looks off here. trunk/src/java/org/apache/hcatalog/data/transfer/ReadEntity.java <https://reviews.apache.org/r/4921/#comment16197> Spacing issue trunk/src/java/org/apache/hcatalog/data/transfer/ReadEntity.java <https://reviews.apache.org/r/4921/#comment16198> Bunch of spacing issues trunk/src/java/org/apache/hcatalog/data/transfer/ReadEntity.java <https://reviews.apache.org/r/4921/#comment16199> Bunch of spacing issues trunk/src/java/org/apache/hcatalog/data/transfer/ReadEntity.java <https://reviews.apache.org/r/4921/#comment16200> Spacing issue trunk/src/java/org/apache/hcatalog/data/transfer/ReadEntity.java <https://reviews.apache.org/r/4921/#comment16201> Spacing issue trunk/src/java/org/apache/hcatalog/data/transfer/ReaderContext.java <https://reviews.apache.org/r/4921/#comment16202> spacing trunk/src/java/org/apache/hcatalog/data/transfer/ReaderContext.java <https://reviews.apache.org/r/4921/#comment16203> spacing trunk/src/java/org/apache/hcatalog/data/transfer/ReaderContext.java <https://reviews.apache.org/r/4921/#comment16204> spacing trunk/src/java/org/apache/hcatalog/data/transfer/ReaderContext.java <https://reviews.apache.org/r/4921/#comment16205> Bunch of spacing issues trunk/src/java/org/apache/hcatalog/data/transfer/ReaderContext.java <https://reviews.apache.org/r/4921/#comment16206> These comments don't look like they match with the function. trunk/src/java/org/apache/hcatalog/data/transfer/ReaderContext.java <https://reviews.apache.org/r/4921/#comment16207> These comments don't look like they match with the function. trunk/src/java/org/apache/hcatalog/data/transfer/WriteEntity.java <https://reviews.apache.org/r/4921/#comment16208> Spacing trunk/src/java/org/apache/hcatalog/data/transfer/WriteEntity.java <https://reviews.apache.org/r/4921/#comment16209> Spacing trunk/src/java/org/apache/hcatalog/data/transfer/WriteEntity.java <https://reviews.apache.org/r/4921/#comment16210> Spacing trunk/src/java/org/apache/hcatalog/data/transfer/WriteEntity.java <https://reviews.apache.org/r/4921/#comment16211> Spacing trunk/src/java/org/apache/hcatalog/data/transfer/WriteEntity.java <https://reviews.apache.org/r/4921/#comment16212> Spacing trunk/src/java/org/apache/hcatalog/data/transfer/WriterContext.java <https://reviews.apache.org/r/4921/#comment16213> Should read "slave nodes for writing" rather than "the writer" trunk/src/java/org/apache/hcatalog/data/transfer/WriterContext.java <https://reviews.apache.org/r/4921/#comment16214> spacing trunk/src/java/org/apache/hcatalog/data/transfer/WriterContext.java <https://reviews.apache.org/r/4921/#comment16216> spacing trunk/src/java/org/apache/hcatalog/data/transfer/WriterContext.java <https://reviews.apache.org/r/4921/#comment16217> These comments dont't seem to match this function. trunk/src/java/org/apache/hcatalog/data/transfer/WriterContext.java <https://reviews.apache.org/r/4921/#comment16218> These comments don't seem to match this function. - Alan On 2012-04-28 00:13:31, Alan Gates wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/4921/ > ----------------------------------------------------------- > > (Updated 2012-04-28 00:13:31) > > > Review request for hcatalog. > > > Summary > ------- > > Javadoc improvements > > > This addresses bug HCATALOG-381. > https://issues.apache.org/jira/browse/HCATALOG-381 > > > Diffs > ----- > > trunk/src/java/org/apache/hcatalog/data/transfer/WriterContext.java 1311550 > trunk/src/java/org/apache/hcatalog/data/transfer/state/StateProvider.java > 1311550 > trunk/src/java/org/apache/hcatalog/data/transfer/ReaderContext.java 1311550 > trunk/src/java/org/apache/hcatalog/data/transfer/WriteEntity.java 1311550 > trunk/src/java/org/apache/hcatalog/data/transfer/ReadEntity.java 1311550 > trunk/src/java/org/apache/hcatalog/data/schema/HCatSchemaUtils.java 1311550 > trunk/src/java/org/apache/hcatalog/data/transfer/EntityBase.java 1311550 > trunk/src/java/org/apache/hcatalog/data/schema/HCatSchema.java 1311550 > trunk/src/java/org/apache/hcatalog/data/HCatRecordable.java 1311550 > trunk/src/java/org/apache/hcatalog/data/schema/HCatFieldSchema.java 1311550 > trunk/src/java/org/apache/hcatalog/data/HCatRecord.java 1311550 > > Diff: https://reviews.apache.org/r/4921/diff > > > Testing > ------- > > > Thanks, > > Alan > >
