[
https://issues.apache.org/jira/browse/HCATALOG-512?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13465265#comment-13465265
]
Daniel Dai commented on HCATALOG-512:
-------------------------------------
bq. What's the error for checkstyle when running on Windows? Its curious that
doesn't run
"File does not end with a newline.". Seems to be a bug in checkstyle on Windows.
bq. This looks problematic because it hard-codes the test output directory
That's true. On Windows, System.getProperty("user.dir") give something like
C:\Users\xxxxx, the file scheme start with C:\ fails to be a valid path. The
relative path is not valid too. "\tmp\xxx" is ugly for sure, I will get rid of
it before commit.
bq. What's the reason for changing these back to strings instead of referencing
the constants?
It's to fix a indeterministic behavior in Hive code.
HiveConf.ConfVars.xxx.varname is initialized to null in HCat unit tests on
Windows. This is because in HiveConf.java, there are two static initialization
section:
{code}
public static final HiveConf.ConfVars[] metaVars
{code}
and
{code}
public static enum ConfVars
{code}
If the first section runs first, then metaVars.varname is null.
This problem should be solved in Hive. But without changing the Hive code,
replacing the enum reference with strings works.
bq. Here we see some platform-specific stuff going on.
That's totally doable, I will update the patch later.
> Fix HCat unit test on Windows
> -----------------------------
>
> Key: HCATALOG-512
> URL: https://issues.apache.org/jira/browse/HCATALOG-512
> Project: HCatalog
> Issue Type: Sub-task
> Affects Versions: 0.5
> Reporter: Daniel Dai
> Assignee: Daniel Dai
> Fix For: 0.5
>
> Attachments: HCATALOG-512-1.patch
>
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
