> On Oct. 2, 2012, 5:54 p.m., Travis Crawford wrote: > > src/java/org/apache/hcatalog/mapreduce/HCatBaseInputFormat.java, line 237 > > <https://reviews.apache.org/r/7384/diff/1/?file=172494#file172494line237> > > > > This is another example of a public method that might be a bit > > permissive. The only main codepath usage I found is: > > > > HCatBaseInputFormat.getOutputSchema() > > > > However, its called quite a few times from tests. Perhaps we should > > annotate this as: > > > > @InterfaceAudience.Private > > @InterfaceStability.Evolving > > > > and change the signature. > > > > Somewhat related note: when adding these wrapper classes, I find > > javadocs get out-of-date when copied like this. Perhaps use @see and have > > the description in just one place?
- Nitay ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/7384/#review12104 ----------------------------------------------------------- On Oct. 1, 2012, 11:34 p.m., Nitay Joffe wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/7384/ > ----------------------------------------------------------- > > (Updated Oct. 1, 2012, 11:34 p.m.) > > > Review request for hcatalog. > > > Description > ------- > > HCATALOG-516: HCOF refactor to allow calling without Job > > > Diffs > ----- > > src/java/org/apache/hcatalog/common/HCatUtil.java > 10446e163a3671799bf4eb16b5a112bf4d7cd1e3 > src/java/org/apache/hcatalog/mapreduce/HCatBaseInputFormat.java > 3532696410ae9da17a815c03aa35d85ffc446152 > src/java/org/apache/hcatalog/mapreduce/HCatBaseOutputFormat.java > d741b7fbd1bb8bc3da19064cfc1e733267ee9ee7 > src/java/org/apache/hcatalog/mapreduce/HCatInputFormat.java > b668d7ad8cbe45602b668b560cd39d465151785a > src/java/org/apache/hcatalog/mapreduce/HCatOutputFormat.java > 30c9e6bce0181b21e01356eedebaa2781f06b8a3 > src/java/org/apache/hcatalog/mapreduce/InitializeInput.java > ce6562383e55ff80c75731da3ba780373e58c9a6 > src/java/org/apache/hcatalog/mapreduce/Security.java > 041a89845f78d5773edac5a50eeab1a15993e528 > > Diff: https://reviews.apache.org/r/7384/diff/ > > > Testing > ------- > > > Thanks, > > Nitay Joffe > >
