----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/7384/#review12425 -----------------------------------------------------------
AFAICT this looks pretty good, thanks for making these changes. I downloaded the patch from RB but it would not apply in svn nor git repos. Can you rebase + repost this patch to Jira? Eyeballing things I think it looks good, but also want to run tests and poke around a bit more to make sure we're not breaking anything. - Travis Crawford On Oct. 9, 2012, 10:47 p.m., Nitay Joffe wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/7384/ > ----------------------------------------------------------- > > (Updated Oct. 9, 2012, 10:47 p.m.) > > > Review request for hcatalog. > > > Description > ------- > > HCATALOG-516: HCOF refactor to allow calling without Job > > > Diffs > ----- > > src/java/org/apache/hcatalog/common/HCatUtil.java > 10446e163a3671799bf4eb16b5a112bf4d7cd1e3 > src/java/org/apache/hcatalog/mapreduce/HCatBaseInputFormat.java > 3532696410ae9da17a815c03aa35d85ffc446152 > src/java/org/apache/hcatalog/mapreduce/HCatBaseOutputFormat.java > d741b7fbd1bb8bc3da19064cfc1e733267ee9ee7 > src/java/org/apache/hcatalog/mapreduce/HCatInputFormat.java > b668d7ad8cbe45602b668b560cd39d465151785a > src/java/org/apache/hcatalog/mapreduce/HCatOutputFormat.java > 30c9e6bce0181b21e01356eedebaa2781f06b8a3 > src/java/org/apache/hcatalog/mapreduce/InitializeInput.java > df5afad1fb6ed0b7a4ce3b5cf13a620fecb9bcb1 > src/java/org/apache/hcatalog/mapreduce/Security.java > 041a89845f78d5773edac5a50eeab1a15993e528 > > Diff: https://reviews.apache.org/r/7384/diff/ > > > Testing > ------- > > > Thanks, > > Nitay Joffe > >
