> On Oct. 29, 2012, 6:50 a.m., Francis Liu wrote: > > ant/e2e.xml, line 1 > > <https://reviews.apache.org/r/7707/diff/1/?file=179174#file179174line1> > > > > Do we really need another import file? This doesn't look like something > > that will be shared?
Agreed - this isn't something that's intended to be shared. Its a separate file to help manage the complexity of our build. Having a single ginormous build.xml really makes it confusing, and by having all the e2e stuff in one smaller file it really clarifies how that part of our build works. > On Oct. 29, 2012, 6:50 a.m., Francis Liu wrote: > > ant/e2e.xml, line 46 > > <https://reviews.apache.org/r/7707/diff/1/?file=179174#file179174line46> > > > > Teardown after all the tests are run as well and prolly only do that if > > test-e2e-setup was run? Good suggestion, I'll update the patch. - Travis ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/7707/#review12868 ----------------------------------------------------------- On Oct. 23, 2012, 7:03 p.m., Travis Crawford wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/7707/ > ----------------------------------------------------------- > > (Updated Oct. 23, 2012, 7:03 p.m.) > > > Review request for hcatalog. > > > Description > ------- > > This patch simplifies running HCatalog's end-to-end tests on your local > machine. > > It takes care of downloading, configuring & starting: Hadoop, Hive, Pig, > HBase, and ZooKeeper. > > It does not setup MySQL, passwordless SSH, or install the required perl > module. Users still need to perform these steps. I don't think its > appropriate for the build scripts to do this as it requires making > environmental changes that IMHO a build system should not do. > > Note: when applying this patch locally, you need to: > > chmod 755 build-support/scripts/e2e-stop-daemons.sh > > These permissions are lost when creating the diff. > > > This addresses bug HCATALOG-535. > https://issues.apache.org/jira/browse/HCATALOG-535 > > > Diffs > ----- > > .gitignore e421e48 > ant/e2e.xml PRE-CREATION > build-support/e2e/conf/hadoop/core-site.xml PRE-CREATION > build-support/e2e/conf/hadoop/hadoop-env.sh PRE-CREATION > build-support/e2e/conf/hadoop/hdfs-site.xml PRE-CREATION > build-support/e2e/conf/hadoop/log4j.properties PRE-CREATION > build-support/e2e/conf/hadoop/mapred-site.xml PRE-CREATION > build-support/e2e/conf/hbase/hbase-site.xml PRE-CREATION > build-support/e2e/conf/hive/hive-site.xml PRE-CREATION > build-support/resources/README PRE-CREATION > build-support/scripts/e2e-stop-daemons.sh PRE-CREATION > build.xml 0d8918d > src/test/e2e/hcatalog/drivers/Util.pm 9c13f06 > src/test/e2e/hcatalog/udfs/java/build.xml 6486882 > > Diff: https://reviews.apache.org/r/7707/diff/ > > > Testing > ------- > > All e2e tests pass locally, except Pig_Complex_6 which I believe the test > itself has an issue. > > > Thanks, > > Travis Crawford > >
