-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/8095/#review13713
-----------------------------------------------------------
Tried it out looking good. Though wouldn't it be cleaner to hardcode the
profiles for webhcat in the build file instead of replicating the profiles
across the pom submodules? I tried it out and it seems possible. Here's the
general idea, now users specify the profile property instead of mvn.profile.
BTW we should probably call it hadoop profile instead?
<target name="jar" depends="init" description="build all jars">
<ant target="jar" dir="core" inheritAll="false">
- <property name="mvn.profile" value="${mvn.profile}"/>
+ <property name="mvn.profile" value="${profile}"/>
</ant>
<ant target="jar" dir="hcatalog-pig-adapter" inheritAll="false">
- <property name="mvn.profile" value="${mvn.profile}"/>
+ <property name="mvn.profile" value="${profile}"/>
</ant>
<ant target="jar" dir="server-extensions" inheritAll="false">
- <property name="mvn.profile" value="${mvn.profile}"/>
+ <property name="mvn.profile" value="${profile}"/>
</ant>
<ant target="jar" dir="webhcat/svr" inheritAll="false">
- <property name="mvn.profile" value="${mvn.profile}"/>
+ <property name="mvn.profile" value="hadoop20"/>
</ant>
<ant target="jar" dir="webhcat/java-client" inheritAll="false">
- <property name="mvn.profile" value="${mvn.profile}"/>
+ <property name="mvn.profile" value="${profile}"/>
</ant>
<ant target="jar" dir="storage-handlers/hbase" inheritAll="false">
- <property name="mvn.profile" value="${mvn.profile}"/>
+ <property name="mvn.profile" value="hadoop20"/>
</ant>
</target>
- Francis Liu
On Nov. 16, 2012, 9:46 p.m., Travis Crawford wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/8095/
> -----------------------------------------------------------
>
> (Updated Nov. 16, 2012, 9:46 p.m.)
>
>
> Review request for hcatalog and Francis Liu.
>
>
> Description
> -------
>
> Add hadoop 23 build support to HCatalog through maven profiles.
>
> A new ./build-support/scripts/test.sh script has been added where we can put
> the command we want people to run when testing, so we're all on the same page.
>
> Note this adds a required -Dmvn.profile ant option. Do you think we should
> have a default?
>
>
> This addresses bug HCATALOG-542.
> https://issues.apache.org/jira/browse/HCATALOG-542
>
>
> Diffs
> -----
>
> ant/deploy.xml e0f5ea3
> build-common.xml 0e0af1c
> build-support/scripts/test.sh PRE-CREATION
> build.properties d75f5de
> build.xml 61ff391
> core/pom.xml d6e2358
> hcatalog-pig-adapter/pom.xml 04d28b7
> pom.xml 6ade4a6
> server-extensions/pom.xml eaac449
> storage-handlers/hbase/pom.xml 6066b4b
> webhcat/java-client/pom.xml 882abd7
> webhcat/svr/pom.xml 3ae03e7
>
> Diff: https://reviews.apache.org/r/8095/diff/
>
>
> Testing
> -------
>
> Ran ./build-support/scripts/test.sh locally and at
> https://travis.ci.cloudbees.com/job/travis_mvn_profiles/
>
>
> Thanks,
>
> Travis Crawford
>
>
