> On Nov. 26, 2012, 9:38 p.m., Francis Liu wrote: > > Looks good. One small nitpick can we rename mvn.profile to hadoop.profile? > > Maven supports the activation of multiple profiles and this profile is > > clearly for hadoop versions. I'm +1 if you're ok with that change.
How about "mvn.hadoop.profile" – I'd like to keep the mvn namespace for all the dependency stuff. - Travis ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/8095/#review13751 ----------------------------------------------------------- On Nov. 26, 2012, 5:28 p.m., Travis Crawford wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/8095/ > ----------------------------------------------------------- > > (Updated Nov. 26, 2012, 5:28 p.m.) > > > Review request for hcatalog and Francis Liu. > > > Description > ------- > > Add hadoop 23 build support to HCatalog through maven profiles. > > A new ./build-support/scripts/test.sh script has been added where we can put > the command we want people to run when testing, so we're all on the same page. > > Note this adds a required -Dmvn.profile ant option. Do you think we should > have a default? > > > This addresses bug HCATALOG-542. > https://issues.apache.org/jira/browse/HCATALOG-542 > > > Diffs > ----- > > ant/deploy.xml e0f5ea3 > build-common.xml 0e0af1c > build-support/scripts/test.sh PRE-CREATION > build.properties d75f5de > build.xml 61ff391 > core/build.xml c5ad2c1 > core/pom.xml d6e2358 > pom.xml 6ade4a6 > shims/build.xml b13c7bd > webhcat/svr/pom.xml 3ae03e7 > > Diff: https://reviews.apache.org/r/8095/diff/ > > > Testing > ------- > > Ran ./build-support/scripts/test.sh locally and at > https://travis.ci.cloudbees.com/job/travis_mvn_profiles/ > > > Thanks, > > Travis Crawford > >
